shoulda

Comments and changes to this ticket

• 

  Tammer Saleh May 19th, 2008 @ 11:00 AM

  Hi Seth,

  Yeah, a macro for testing exact length validations would be useful.

  Feel free to make a git fork with the changes and tests.

  Cheers,

  Tammer

• 

  Tammer Saleh May 20th, 2008 @ 01:57 PM

  • → State changed from “new” to “needs-git-fork”
  • → Assigned user cleared.
• 

  Chris O'Sullivan June 19th, 2008 @ 12:35 PM

  Heya

  I've created a git fork with this functionality (with tests and docs).

  Find it here: http://github.com/thechrisoshow/...

  -Chris

• 

  Tammer Saleh June 26th, 2008 @ 05:05 PM

  • → Tag cleared.

  Hi Chris,

  This looks like a great patch, but it seems to be gone from the repository? Is there any way you can reapply those changes? If you do, I'll be sure to commit it.

  This was my mistake. Thanks for the patch.

  Cheers,

  Tammer

• 

  Tammer Saleh June 26th, 2008 @ 05:05 PM

  • → State changed from “needs-git-fork” to “good-to-go”
• 

  Chris O'Sullivan June 26th, 2008 @ 05:06 PM

  (still getting to grips with this github malarkey)

  This link here points the way to the branch that contains the patch:

  http://github.com/thechrisoshow/...

  Is this cool?

• 

  Tammer Saleh June 26th, 2008 @ 05:12 PM

  • → State changed from “good-to-go” to “committed”
• 

  Tammer Saleh June 26th, 2008 @ 05:41 PM

  Chris: Yeah, it's all good. Still getting the hang of git.