Avoid double printing of deferred should_eventuallys in nested contexts
Reported by Ryan McGeary | June 27th, 2008 @ 10:06 PM
Hi. Here's a quick fix that avoids double printing of deferred statements when should_eventuallys are in nested contexts. Test included.
(rmm5t/shoulda master 5aed592)
http://github.com/rmm5t/shoulda/...
For example, this:
context "context" do
context "with nested subcontexts" do
should_eventually "only print this statement once for a should_eventually"
end
end
used to print this:
* DEFERRED: context with nested subcontexts should only print this statement once for a should_eventually.
* DEFERRED: context with nested subcontexts should only print this statement once for a should_eventually.
but this patch fixes that:
* DEFERRED: context with nested subcontexts should only print this statement once for a should_eventually.
(Sorry about already submitting a github pull request to Tammer. I read the mailing list submission guidelines only afterwards.)
Comments and changes to this ticket
-
Ryan McGeary June 28th, 2008 @ 07:28 AM
I see my pull request was accepted. This ticket can be closed.
http://github.com/thoughtbot/sho...
Sorry for clogging your internets :)
-
Tammer Saleh June 28th, 2008 @ 08:34 AM
- → State changed from “new” to “committed”
Thanks for the fix, Ryan.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
