12160 1 true 2008-09-16T20:44:46-04:00 12160 80 conditionally-choose-i18n-or-ar-for-error-messages 27966 5807 committed active_record_helper 2008-09-19T21:53:37-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 To support edge Rails and a future Rails 2.2 release, the AR macro helpers should pull default expected error messages from `I18n.translate('active_record.error_messages')` instead of `ActiveRecord::Errors.default_error_messages` This will avoid deprecation messages like this: @@@ DEPRECATION WARNING: ActiveRecord::Errors.default_error_messages has been deprecated. Please use I18n.translate('active_record.error_messages'). @@@ To maintain backwards compatibility, fallback to `#default_error_messages` if `I18n` isn't defined. To support edge Rails and a future Rails 2.2 release, the AR macro helpers should pull default expected error messages from `I18n.translate('active_record.error_messages')` instead of `ActiveRecord::Errors.default_error_messages` This will avoid deprecation messages like this: @@@ DEPRECATION WARNING: ActiveRecord::Errors.default_error_messages has been deprecated. Please use I18n.translate('active_record.error_messages'). @@@ To maintain backwards compatibility, fallback to `#default_error_messages` if `I18n` isn't defined. <div><p>To support edge Rails and a future Rails 2.2 release, the AR macro helpers should pull default expected error messages from <code>I18n.translate('active_record.error_messages')</code> instead of <code>ActiveRecord::Errors.default_error_messages</code></p> <p>This will avoid deprecation messages like this:</p> <pre><code> DEPRECATION WARNING: ActiveRecord::Errors.default_error_messages has been deprecated. Please use I18n.translate('active_record.error_messages'). </code></pre> <p>To maintain backwards compatibility, fallback to <code>#default_error_messages</code> if <code>I18n</code> isn't defined.</p></div> 12160 0 To support edge Rails and a future Rails 2.2 release, the AR macro helpers should pull default expected error messages from `I18n.translate('active_record.error_messages')` instead of `ActiveRecord::Errors.default_error_messages` This will avoid deprecation messages like this: @@@ DEPRECATION WARNING: ActiveRecord::Errors.default_error_messages has been deprecated. Please use I18n.translate('active_record.error_messages'). @@@ To maintain backwards compatibility, fallback to `#default_error_messages` if `I18n` isn't defined. <div><p>To support edge Rails and a future Rails 2.2 release, the AR macro helpers should pull default expected error messages from <code>I18n.translate('active_record.error_messages')</code> instead of <code>ActiveRecord::Errors.default_error_messages</code></p> <p>This will avoid deprecation messages like this:</p> <pre><code> DEPRECATION WARNING: ActiveRecord::Errors.default_error_messages has been deprecated. Please use I18n.translate('active_record.error_messages'). </code></pre> <p>To maintain backwards compatibility, fallback to <code>#default_error_messages</code> if <code>I18n</code> isn't defined.</p></div> false 2008-09-16T20:44:46-04:00 12160 --- {} 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 new active_record_helper 2008-09-16T20:44:50-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 0 http://github.com/thoughtbot/shoulda/commit/c60fa4be85af2c8273460c7fc0881847b4dbd171 <div><p><a href="http://github.com/thoughtbot/shoulda/commit/c60fa4be85af2c8273460c7fc0881847b4dbd171"> http://github.com/thoughtbot/sho...</a></p></div> true 2008-09-16T21:21:07-04:00 12160 --- :state: new 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 committed active_record_helper 2008-09-16T21:21:08-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 0 It's hard to keep up with Rails! What about this stray use of default_error_messages? http://github.com/thoughtbot/shoulda/tree/master/lib/shoulda/active_record/assertions.rb#L60 <div><p>It's hard to keep up with Rails!</p> <p>What about this stray use of default_error_messages?</p> <p><a href="http://github.com/thoughtbot/shoulda/tree/master/lib/shoulda/active_record/assertions.rb#L60"> http://github.com/thoughtbot/sho...</a></p></div> true 2008-09-16T21:49:05-04:00 12160 --- {} 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 committed active_record_helper 2008-09-16T21:49:08-04:00 17465 Mike Boone Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 0 Mike, Good catch. Fixed. Thanks. http://github.com/thoughtbot/shoulda/commit/feed1087bd185fcef97624ab2328f94f59415a2a <div><p>Mike, Good catch. Fixed. Thanks.</p> <p><a href="http://github.com/thoughtbot/shoulda/commit/feed1087bd185fcef97624ab2328f94f59415a2a"> http://github.com/thoughtbot/sho...</a></p></div> true 2008-09-16T21:58:31-04:00 12160 --- {} 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 committed active_record_helper 2008-09-16T21:58:34-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 0 There seems to be a problem with the key that's being used in this patch. The actual key I have in my edge rails is "activerecord.errors.messages". I suppose it changed at some point. Attached a patch to fix the key and the documentation references to it. <div><p>There seems to be a problem with the key that's being used in this patch.</p> <p>The actual key I have in my edge rails is "activerecord.errors.messages". I suppose it changed at some point.</p> <p>Attached a patch to fix the key and the documentation references to it.</p></div> true 2008-09-18T11:28:42-04:00 12160 --- {} 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 committed active_record_helper 2008-09-18T11:28:43-04:00 3565 Cristi Balan Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 1 Cristi, Thanks. I'll push this later today. <div><p>Cristi, Thanks. I'll push this later today.</p></div> false 2008-09-18T12:10:20-04:00 12160 --- :state: committed 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 good-to-go active_record_helper 2008-09-18T12:10:22-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 12160 1 Edge rails naming problems fixed. You're right Cristi. Rails did rename that key. Thanks! http://github.com/thoughtbot/shoulda/commit/8a111a6e815fc2a94567d709667a13850b98b5ab Considering it's edge rails, shoulda should only support the current key name. <div><p>Edge rails naming problems fixed. You're right Cristi. Rails did rename that key. Thanks!</p> <p><a href="http://github.com/thoughtbot/shoulda/commit/8a111a6e815fc2a94567d709667a13850b98b5ab"> http://github.com/thoughtbot/sho...</a></p> <p>Considering it's edge rails, shoulda should only support the current key name.</p></div> true 2008-09-19T21:53:33-04:00 12160 --- :state: good-to-go 80 conditionally-choose-i18n-or-ar-for-error-messages 0 5807 committed active_record_helper 2008-09-19T21:53:37-04:00 12160 Ryan McGeary Ryan McGeary Ryan McGeary http://thoughtbot.lighthouseapp.com/projects/5807/tickets/80 9476a81e8e3579fac671cdd7c1adcc3e7d85062b text/plain 2008-09-18T11:28:42-04:00 0001-fix-I18n.translate-key-for-edge-rails.patch 46910 6025 3565 http://thoughtbot.lighthouseapp.com/attachments/46910/0001-fix-I18n.translate-key-for-edge-rails.patch