Only partial boundary checking in 'should_ensure_length_in_range'
Reported by Earle Clubb | January 10th, 2008 @ 02:16 PM
should_ensure_length_in_range only tests outside the range, not at the valid endpoints. In other words, tests are only performed to check for failures at min-1 and max+1. A patch similar to that submitted in ticket #10 would mostly work, but there needs to be some way of knowing how to build a string using valid characters. For example, a password field often requires at least one digit, etc.
Comments and changes to this ticket
-
Tammer Saleh January 21st, 2008 @ 09:37 AM
- → State changed from “new” to “open”
Do you think it would be fine if we only checked to ensure that saving a value that's within the length range didn't result in a /short/ error on that attribute? That would get around the valid character issues most of the time.
-
-
Tammer Saleh February 28th, 2008 @ 05:34 PM
- → State changed from “open” to “resolved”
Thanks Earle,
I've committed this to trunk.
Cheers,
Tammer
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
