17223 0 true 2009-02-17T13:22:26-05:00 47724 2009-05-22T00:00:00-04:00 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 1 5807 resolved case_insensitive should_validate_uniqueness_of 2010-01-17T05:17:04-05:00 53404 Vladimir Rybas papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11 model/episode.rb @@@ruby class Episode < ActiveRecord::Base belongs_to :user belongs_to :program has_one :video validates_presence_of :title validates_presence_of :description validates_presence_of :user_id validates_uniqueness_of :title, :case_sensitive => false end @@@ test/unit/episode_test.rb @@@ruby require 'test_helper' class EpisodeTest < ActiveSupport::TestCase should_belong_to :user should_validate_uniqueness_of :title, :case_sensitive => false end @@@ results of rake: @@@ 1) Failure: test: Episode should require unique value for title. (EpisodeTest) []: @@@ Am I missing something obvious? model/episode.rb @@@ruby class Episode < ActiveRecord::Base belongs_to :user belongs_to :program has_one :video validates_presence_of :title validates_presence_of :description validates_presence_of :user_id validates_uniqueness_of :title, :case_sensitive => false end @@@ test/unit/episode_test.rb @@@ruby require 'test_helper' class EpisodeTest < ActiveSupport::TestCase should_belong_to :user should_validate_uniqueness_of :title, :case_sensitive => false end @@@ results of rake: @@@ 1) Failure: test: Episode should require unique value for title. (EpisodeTest) []: @@@ Am I missing something obvious? <div><p>model/episode.rb @@@ruby class Episode &lt; ActiveRecord::Base belongs_to :user belongs_to :program has_one :video</p> <p>validates_presence_of :title validates_presence_of :description validates_presence_of :user_id</p> <p>validates_uniqueness_of :title, :case_sensitive =&gt; false end</p> <pre><code> test/unit/episode_test.rb @@@ruby require 'test_helper' class EpisodeTest &lt; ActiveSupport::TestCase should_belong_to :user should_validate_uniqueness_of :title, :case_sensitive =&gt; false end </code></pre> <p>results of rake:</p> <pre><code> 1) Failure: test: Episode should require unique value for title. (EpisodeTest) []: </code></pre> <p>Am I missing something obvious?</p></div> 0 model/episode.rb @@@ ruby class Episode < ActiveRecord::Base belongs_to :user belongs_to :program has_one :video validates_presence_of :title validates_presence_of :description validates_presence_of :user_id validates_uniqueness_of :title, :case_sensitive => false end @@@ test/unit/episode_test.rb @@@ ruby require 'test_helper' class EpisodeTest < ActiveSupport::TestCase should_belong_to :user should_validate_uniqueness_of :title, :case_sensitive => false end @@@ results of rake: @@@ sh 1) Failure: test: Episode should require unique value for title. (EpisodeTest) []: @@@ Am I missing something obvious? <div><p>model/episode.rb</p> <pre><code class="ruby"> class Episode &lt; ActiveRecord::Base belongs_to :user belongs_to :program has_one :video validates_presence_of :title validates_presence_of :description validates_presence_of :user_id validates_uniqueness_of :title, :case_sensitive =&gt; false end </code></pre> <p>test/unit/episode_test.rb</p> <pre><code class="ruby"> require 'test_helper' class EpisodeTest &lt; ActiveSupport::TestCase should_belong_to :user should_validate_uniqueness_of :title, :case_sensitive =&gt; false end </code></pre> <p>results of rake:</p> <pre><code class="sh"> 1) Failure: test: Episode should require unique value for title. (EpisodeTest) []: </code></pre> <p>Am I missing something obvious?</p></div> false 2009-02-17T13:22:28-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new should_validate_uniqueness_of 2009-02-17T13:25:11-05:00 47724 papyromancer papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 I'm seeing this too; occurs for my existing app. However, I can't reproduce on a fresh app. Haven't pinned it down to anything yet. <div><p>I'm seeing this too; occurs for my existing app. However, I can't reproduce on a fresh app. Haven't pinned it down to anything yet.</p></div> false 2009-02-19T18:00:01-05:00 47724 --- :tag: should_validate_uniqueness_of 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-02-19T18:00:03-05:00 3685 Jonathan Sutherland papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 I'm getting this even without specifying :case_sensitive. <div><p>I'm getting this even without specifying :case_sensitive.</p></div> false 2009-02-27T20:41:18-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-02-27T20:41:21-05:00 48740 Raphomet papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 Hmm. I fixed it by moving my should_validate_uniqueness_of macro into a context block with a setup that generates my model from a Factory. <div><p>Hmm. I fixed it by moving my should_validate_uniqueness_of macro into a context block with a setup that generates my model from a Factory.</p></div> false 2009-02-27T20:44:30-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-02-27T20:44:35-05:00 48740 Raphomet papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 I'm seeing the same message as Jonathan when I'm running my tests for a similar 2 models that I am trying to test. @@@ ruby class FactorTest < ActiveSupport::TestCase should_belong_to :project should_validate_presence_of :name should_validate_uniqueness_of :name, :case_sensitive => false, :scoped_to => :project_id end @@@ which is the test for: @@@ ruby class Factor < ActiveRecord::Base belongs_to :project validates_presence_of :name validates_uniqueness_of :name, :case_sensitive => false, :scope => :project_id end @@@ @Raphomet - Which model are you generating from a Factory? Are you generating the model the test is for or the model that contains the scope? <div><p>I'm seeing the same message as Jonathan when I'm running my tests for a similar 2 models that I am trying to test.</p> <pre><code class="ruby"> class FactorTest &lt; ActiveSupport::TestCase should_belong_to :project should_validate_presence_of :name should_validate_uniqueness_of :name, :case_sensitive =&gt; false, :scoped_to =&gt; :project_id end </code></pre> <p>which is the test for:</p> <pre><code class="ruby"> class Factor &lt; ActiveRecord::Base belongs_to :project validates_presence_of :name validates_uniqueness_of :name, :case_sensitive =&gt; false, :scope =&gt; :project_id end </code></pre> <p>@Raphomet - Which model are you generating from a Factory? Are you generating the model the test is for or the model that contains the scope?</p></div> false 2009-02-28T10:15:36-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-02-28T10:15:37-05:00 48799 Matthew Lang papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 @Matthew Lang The model the Test is for: @@@ class TagTest < ActiveSupport::TestCase context "A tag" do setup do @tag = Factory(:tag) end should_validate_uniqueness_of :name, :case_sensitive => false end end @@@ I'm using Factory Girl. I'm not sure if this is the intended behavior from the developers, but it cleared up the error for me right away. Hope that helps! <div><p>@Matthew Lang</p> <p>The model the Test is for:</p> <pre><code> class TagTest &lt; ActiveSupport::TestCase context &quot;A tag&quot; do setup do @tag = Factory(:tag) end should_validate_uniqueness_of :name, :case_sensitive =&gt; false end end </code></pre> <p>I'm using Factory Girl. I'm not sure if this is the intended behavior from the developers, but it cleared up the error for me right away. Hope that helps!</p></div> false 2009-02-28T15:38:45-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-02-28T15:38:50-05:00 48740 Raphomet papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 0 Thanks for the Raphomet. So a factory for the model instance needs to be created when your validating the uniqueness of something. Makes sense, but which I thought of this earlier. <div><p>Thanks for the Raphomet.</p> <p>So a factory for the model instance needs to be created when your validating the uniqueness of something.</p> <p>Makes sense, but which I thought of this earlier.</p></div> false 2009-03-03T08:25:01-05:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-03-03T08:25:05-05:00 48799 Matthew Lang papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 17223 0 This is the expected behavior for this macro, but it's supposed to print out an error message when no existing records can be found. I'll look into why this error disappeared. <div><p>This is the expected behavior for this macro, but it's supposed to print out an error message when no existing records can be found. I'll look into why this error disappeared.</p></div> false 2009-03-03T10:25:47-05:00 47724 --- :assigned_user: 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-03-03T10:25:51-05:00 17223 Joe Ferris papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 17223 0 I think the root cause of this issue is because should_validate_uniqueness_of is testing a 'nil' scenario. For a model whose only validation is validates_uniqueness_of, I get: @@@ 1) Failure: test: Page should require case sensitive unique value for title. (PageTest) ... vendor/gems/thoughtbot-shoulda-2.10.1/lib/shoulda/context.rb:253:in `test: Page should require case sensitive unique value for title. ']: errors to include "has already been taken" when title is set to nil, got no errors @@@ For validates_uniqueness_of, Rails doesn't add an error when the attr is nil (that's the job of validates_presence_of). Haven't looked further as to why it's testing nil yet. <div><p>I think the root cause of this issue is because should_validate_uniqueness_of is testing a 'nil' scenario.</p> <p>For a model whose only validation is validates_uniqueness_of, I get:</p> <pre><code> 1) Failure: test: Page should require case sensitive unique value for title. (PageTest) ... vendor/gems/thoughtbot-shoulda-2.10.1/lib/shoulda/context.rb:253:in `test: Page should require case sensitive unique value for title. ']: errors to include &quot;has already been taken&quot; when title is set to nil, got no errors </code></pre> <p>For validates_uniqueness_of, Rails doesn't add an error when the attr is nil (that's the job of validates_presence_of).</p> <p>Haven't looked further as to why it's testing nil yet.</p></div> false 2009-03-22T09:23:56-04:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-03-22T09:24:01-04:00 3685 Jonathan Sutherland papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 17223 0 Inside validate_uniqueness_of_matcher.rb there's the following doc: <code> # Internally, this uses values from existing records to test validations, # so this will always fail if you have not saved at least one record for # the model being tested, like so: </code> ... which sums it up nicely :P This issue stung me also. I think a "there was no records to clone" error at test time would be good, as well as the above doc added to the should_validate_uniqueness_of doc... ? <div><p>Inside validate_uniqueness_of_matcher.rb there's the following doc:</p> <pre> <code> # Internally, this uses values from existing records to test validations, # so this will always fail if you have not saved at least one record for # the model being tested, like so: </code> </pre> <p>... which sums it up nicely :P</p> <p>This issue stung me also. I think a "there was no records to clone" error at test time would be good, as well as the above doc added to the should_validate_uniqueness_of doc... ?</p></div> false 2009-04-04T20:29:48-04:00 47724 --- {} 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-04-04T20:29:53-04:00 40291 Alex Pooley papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 17223 0 false 2009-05-05T15:48:24-04:00 47724 --- :milestone: 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-05-05T15:48:27-04:00 17223 Joe Ferris papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11 0 false 2009-05-05T19:37:12-04:00 47724 --- :assigned_user: 17223 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-05-05T19:37:15-04:00 17223 Joe Ferris papyromancer http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11 17223 0 false 2009-06-09T20:45:05-04:00 47724 --- :assigned_user: 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 new case_insensitive should_validate_uniqueness_of 2009-06-09T20:45:05-04:00 17223 Joe Ferris papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11 17223 0 I believe this was fixed by this commit: http://github.com/thoughtbot/shoulda/commit/1ce9339d9c452d39c60eb2fd04156104e6e133e4 Please open a ticket over at Github issues if this problem persists after the next release of Shoulda: http://github.com/thoughtbot/shoulda/issues Thanks, -Joe <div><p>I believe this was fixed by this commit: <a href= "http://github.com/thoughtbot/shoulda/commit/1ce9339d9c452d39c60eb2fd04156104e6e133e4"> http://github.com/thoughtbot/shoulda/commit/1ce9339d9c452d39c60eb2f...</a></p> <p>Please open a ticket over at Github issues if this problem persists after the next release of Shoulda: <a href= "http://github.com/thoughtbot/shoulda/issues">http://github.com/thoughtbot/shoulda/issues</a></p> <p>Thanks,</p> <p>-Joe</p></div> true 2009-06-09T20:56:09-04:00 47724 --- :state: new 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 resolved case_insensitive should_validate_uniqueness_of 2009-06-09T20:56:09-04:00 17223 Joe Ferris papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11 17223 0 Could be done like that, while using Rspec and Factory Girl @@@ ruby lambda {Factory(:user); should_validate_uniqueness_of(:email); User.delete_all}.call @@@ <div><p>Could be done like that, while using Rspec and Factory Girl<br></p> <pre> <code class= "ruby">lambda {Factory(:user); should_validate_uniqueness_of(:email); User.delete_all}.call</code> </pre></div> true 2010-01-17T05:17:02-05:00 47724 --- {} 39155 164 should_validate_uniqueness_of-model-case_sensitive-false-doesnt-validate-at-least-for-me 0 5807 resolved case_insensitive should_validate_uniqueness_of 2010-01-17T05:17:04-05:00 53404 Vladimir Rybas papyromancer Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/164 2.11