shoulda

Comments and changes to this ticket

• 

  Tammer Saleh February 28th, 2008 @ 04:36 PM

  • → State changed from “new” to “open”

  Hi Earle,

  I'm not sure I see the issue. Could you upload an example test that doesn't work as expected?

  Tammer

• 

  Anthony Caliendo March 3rd, 2008 @ 01:33 PM

  There was an issue opened against #classify in Rails 2. Please see this Rails Trac issue: http://dev.rubyonrails.org/ticke... .

  The gist of it is that "address".classify will return "Addres" instead of "Address". The reason for this is because the #classify method is expected to be passed the plural form, not the singular form.

  I took the advice listed in the rails bug and changed line 385 in active_record_helpers.rb to use #camelize instead of #classify (see attached patch). The unit test in my code which was failing before worked after this change (I didn't include the test in the patch since it was specific to my codebase). I was using shoulda revision 378.

  I'm not sure if there would be any side effects from this change, but I hope this information helps.

• 

  Anthony Caliendo March 3rd, 2008 @ 01:37 PM

  I just realized that Earle's patch was exactly the same as mine, so I removed it. Sorry for not seeing your attachment sooner!

  However, the reason for the failure remains the same.

• 

  Anthony Caliendo March 3rd, 2008 @ 01:45 PM

  I am attaching a failing test for this issue, which demonstrates that the fix works.

• 

  Tammer Saleh June 26th, 2008 @ 03:25 PM

  • → State changed from “open” to “new”
  • → Assigned user cleared.
  • → Tag cleared.
• 

  Ryan McGeary August 8th, 2008 @ 07:07 PM

  • → State changed from “new” to “committed”
  • → Assigned user changed from “” to “Ryan McGeary”
  • → Tag changed from “” to “should_belong_to”

  Thanks Earle and Anthony.

  This is now fixed: http://github.com/thoughtbot/sho...