shoulda

Comments and changes to this ticket

• 

  bhauff June 10th, 2008 @ 12:24 PM

  I have run in to this problem too I believe. I have a float field in my database, and have added the test:

  should_not_allow_values_for :longitude, "One", "Two Hundred"

  In my model I have:

  validates_numericality_of :longitude

  I get the following error when testing:

  /invalid/ not found in ["is not a number"] when set to "One".

  /invalid/ not found in ["is not a number"] when set to "Two Hundred".

• 

  bhauff June 10th, 2008 @ 12:29 PM

  I was able to get the tests to pass by adding:

  {:message => "is not a number"}

  to the

  should_not_allow_values_for :longitude, "One", "Two Hundred"

  test.

• 

  Tammer Saleh June 10th, 2008 @ 12:55 PM

  This is really a different issue. If shoulda used the builtin hashes, it would still be checking for a particular value that wouldn't match "Numeric". The use of :message to solve this problem is the right way to go.

• 

  Alain Ravet June 23rd, 2008 @ 06:35 AM

  I concur the current behaviour - check against a harcoded regexp fragment - is a problem for any non-English speaking sites.

  Rails let's you dry-ly define in one place all the error messages for your target language, but shoulda forces you to duplicate code like :

    should_require_attributes :name, :message => ActiveRecord::Errors.default_error_messages[:blank]
  

  :message should be required for non-standard messages, not for the default ones.

• 

  Tammer Saleh June 26th, 2008 @ 04:58 PM

  • → Tag changed from “” to “active_record_helper should_require_attributes”
  • → State changed from “new” to “needs-git-fork”
  • → Assigned user cleared.
• 

  Mike Boone September 10th, 2008 @ 08:19 PM

  I changed the error regexes into ActiveRecord error messages in this commit to my GitHub fork:

  http://github.com/boone/shoulda/...

• 

  Tammer Saleh September 12th, 2008 @ 10:22 AM

  • → State changed from “needs-git-fork” to “good-to-go”
• 

  Ryan McGeary September 14th, 2008 @ 09:41 PM

  • → State changed from “good-to-go” to “committed”
  • → Assigned user changed from “” to “Ryan McGeary”

  Cherry-picked and pushed. Thanks Mike!

  http://github.com/thoughtbot/sho...