[PATCH] convert_to_should_syntax fixes
Reported by Bob Showalter | July 29th, 2008 @ 04:07 PM
My branch at http://github.com/showaltb/shoul... gives some attention to convert_to_should_syntax
- Test names were being clobbered by use of tr! (see #31)
- Tests that were already in the should .. do format would have underscores removed. This might be a problem for somebody running the script against a test file containing both new-style and old-style tests.
- The script used "/tmp" hard-coded. Changed to use Dir::tmpdir instead to be more friendly to Win32 or other environments.
- Added a test case in test/other
Comments and changes to this ticket
-
Bob Showalter July 29th, 2008 @ 04:07 PM
- → Title changed from “convert_to_should_syntax fixes” to “[PATCH] convert_to_should_syntax fixes”
-
Ryan McGeary July 30th, 2008 @ 08:35 AM
- → Tag changed from “convert_to_should_syntax” to “convert_to_should_syntax patch”
(committed to thoughtbot/shoulda)
Bob, Thank you very much. Merged into master.
-
Ryan McGeary July 30th, 2008 @ 09:19 AM
- → State changed from “new” to “committed”
- → Assigned user changed from “Tammer Saleh” to “Ryan McGeary”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Tammer Saleh