17223 2 true 2008-09-06T10:50:54-04:00 1016 68 testing-fragmentaction-cache-to-be-generated-or-expired 24509 5807 refused enhancement 2009-06-09T19:51:20-04:00 17223 Joe Ferris Fernando Blat Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 Hi, I have beeing adding some methods for testing that action cache is generated or expired, and the same with fragment cache in functional tests. I attach a patch with the methods added to lib/shoulda/controller/helpers.rb, but I don't know if you consider that the best place. I did this because I needed instance methods. I added also a new cache storage engine at lib/shoulda/test_store.rb Also you can find some tests in posts_controller_test.rb and the new tags_controller_test.rb Take a look if you find this useful :) I have a GitHub branch for it, too: http://github.com/ferblape/shoulda/tree/master Cheers Hi, I have beeing adding some methods for testing that action cache is generated or expired, and the same with fragment cache in functional tests. I attach a patch with the methods added to lib/shoulda/controller/helpers.rb, but I don't know if you consider that the best place. I did this because I needed instance methods. I added also a new cache storage engine at lib/shoulda/test_store.rb Also you can find some tests in posts_controller_test.rb and the new tags_controller_test.rb Take a look if you find this useful :) I have a GitHub branch for it, too: http://github.com/ferblape/shoulda/tree/master Cheers <div><p>Hi,</p> <p>I have beeing adding some methods for testing that action cache is generated or expired, and the same with fragment cache in functional tests.</p> <p>I attach a patch with the methods added to lib/shoulda/controller/helpers.rb, but I don't know if you consider that the best place. I did this because I needed instance methods.</p> <p>I added also a new cache storage engine at lib/shoulda/test_store.rb</p> <p>Also you can find some tests in posts_controller_test.rb and the new tags_controller_test.rb</p> <p>Take a look if you find this useful :)</p> <p>I have a GitHub branch for it, too: <a href="http://github.com/ferblape/shoulda/tree/master">http://github.com/ferblape/shoul...</a></p> <p>Cheers</p></div> 13443 0 Hi, I have beeing adding some methods for testing that action cache is generated or expired, and the same with fragment cache in functional tests. I attach a patch with the methods added to lib/shoulda/controller/helpers.rb, but I don't know if you consider that the best place. I did this because I needed instance methods. I added also a new cache storage engine at lib/shoulda/test_store.rb Also you can find some tests in posts_controller_test.rb and the new tags_controller_test.rb Take a look if you find this useful :) I have a GitHub branch for it, too: http://github.com/ferblape/shoulda/tree/master Cheers <div><p>Hi,</p> <p>I have beeing adding some methods for testing that action cache is generated or expired, and the same with fragment cache in functional tests.</p> <p>I attach a patch with the methods added to lib/shoulda/controller/helpers.rb, but I don't know if you consider that the best place. I did this because I needed instance methods.</p> <p>I added also a new cache storage engine at lib/shoulda/test_store.rb</p> <p>Also you can find some tests in posts_controller_test.rb and the new tags_controller_test.rb</p> <p>Take a look if you find this useful :)</p> <p>I have a GitHub branch for it, too: <a href="http://github.com/ferblape/shoulda/tree/master">http://github.com/ferblape/shoul...</a></p> <p>Cheers</p></div> false 2008-09-06T10:50:54-04:00 1016 --- {} 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-06T10:50:59-04:00 1016 Fernando Blat Fernando Blat Tammer Saleh http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 1 Hi Fernando, This looks like a really useful addition to shoulda, but I have a couple of questions about the patch. Can we do without the call to ActionController::Base.cache_store.clear that's in each setup block? Not only do the setup blocks get called all the time, but we're aiming soon to convert Shoulda to a gem so that it's useable outside of rails projects. Running rake produces the following warnings: <pre> * WARNING: 'test: Logged in viewing posts for a user should respond with success. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should assign @user. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should assign @posts. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should not assign to @foo. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should not assign to @bar. ' is already defined </pre> And finally, is it possible to do away with the "map.connect ':controller/:action/:id'" route in the test suite? I worry that this catch-all route could hide future failures in the tests. Thanks for the help, Tammer <div><p>Hi Fernando,</p> <p>This looks like a really useful addition to shoulda, but I have a couple of questions about the patch.</p> <p>Can we do without the call to ActionController::Base.cache_store.clear that's in each setup block? Not only do the setup blocks get called all the time, but we're aiming soon to convert Shoulda to a gem so that it's useable outside of rails projects.</p> <p>Running rake produces the following warnings:</p> <pre> * WARNING: 'test: Logged in viewing posts for a user should respond with success. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should assign @user. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should assign @posts. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should not assign to @foo. ' is already defined * WARNING: 'test: Logged in viewing posts for a user should not assign to @bar. ' is already defined </pre> <p>And finally, is it possible to do away with the "map.connect ':controller/:action/:id'" route in the test suite? I worry that this catch-all route could hide future failures in the tests.</p> <p>Thanks for the help, Tammer</p></div> false 2008-09-10T09:29:56-04:00 1016 --- :assigned_user: 13443 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-10T09:30:02-04:00 13443 Tammer Saleh Fernando Blat http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 1 Hi! I'm attaching a new patch that: - only clears cache if is defined ActionController and if perform_caching is true - corrects all the warnings - avoids the default route and creates a new resource :tags Thanks for the interest! <div><p>Hi!</p> <p>I'm attaching a new patch that:</p> <ul> <li> <p>only clears cache if is defined ActionController and if perform_caching is true</p> </li> <li> <p>corrects all the warnings</p> </li> <li> <p>avoids the default route and creates a new resource :tags</p> </li> </ul> <p>Thanks for the interest!</p></div> false 2008-09-10T11:44:00-04:00 1016 --- {} 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-10T11:44:02-04:00 1016 Fernando Blat Fernando Blat http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 2 This is a good direction, but I really still don't like that kind of platform specific code being in the setup method at all. It would make more sense to me to submit a patch to rails that clears the cache via ActiveSupport::TestCase. <div><p>This is a good direction, but I really still don't like that kind of platform specific code being in the setup method at all. It would make more sense to me to submit a patch to rails that clears the cache via ActiveSupport::TestCase.</p></div> false 2008-09-10T12:40:07-04:00 1016 --- {} 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-10T12:40:12-04:00 13443 Tammer Saleh Fernando Blat http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 2 Ok, I'll check it out and try to have a second thought when I come back from my holidays in 15 days. Meanwhile, if you want, you can discard the ticket. <div><p>Ok,</p> <p>I'll check it out and try to have a second thought when I come back from my holidays in 15 days.</p> <p>Meanwhile, if you want, you can discard the ticket.</p></div> false 2008-09-10T14:52:25-04:00 1016 --- {} 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-10T14:52:31-04:00 1016 Fernando Blat Fernando Blat http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 2 And what about [hacking the run method](http://www.inwebwetrust.net/post/2008/08/19/redefine-the-run-method-of-test-unit-testcase)? The problem of add the clear method to Rails is that not all cache storages support that method (for example disk store), so, it's quite probable that they don't like that approach. <div><p>And what about <a href="http://www.inwebwetrust.net/post/2008/08/19/redefine-the-run-method-of-test-unit-testcase"> hacking the run method</a>?</p> <p>The problem of add the clear method to Rails is that not all cache storages support that method (for example disk store), so, it's quite probable that they don't like that approach.</p></div> false 2008-09-26T13:22:01-04:00 1016 --- {} 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 new enhancement 2008-09-26T13:22:03-04:00 1016 Fernando Blat Fernando Blat http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 17223 2 Hey Fernando, We're moving over to Github issues: http://github.com/thoughtbot/shoulda/issues If you want to take another shot at this, please resubmit this over there. Thanks, -Joe <div><p>Hey Fernando,</p> <p>We're moving over to Github issues: <a href= "http://github.com/thoughtbot/shoulda/issues">http://github.com/thoughtbot/shoulda/issues</a></p> <p>If you want to take another shot at this, please resubmit this over there.</p> <p>Thanks,<br> -Joe</p></div> true 2009-06-09T19:51:20-04:00 1016 --- :state: new :assigned_user: 68 testing-fragmentaction-cache-to-be-generated-or-expired 0 5807 refused enhancement 2009-06-09T19:51:20-04:00 17223 Joe Ferris Fernando Blat Joe Ferris http://thoughtbot.lighthouseapp.com/projects/5807/tickets/68 df8b37fd641344be1a789e8996cdecfe3b55032e text/plain 2008-09-06T10:50:54-04:00 0001-Added-some-should-methods-for-testing-fragment-page.patch 44213 13037 1016 http://thoughtbot.lighthouseapp.com/attachments/44213/0001-Added-some-should-methods-for-testing-fragment-page.patch 61bdf28ab73914cdaef28e1a505b294ee533f9df text/plain 2008-09-10T11:44:00-04:00 cache_assertions.diff 45067 17444 1016 http://thoughtbot.lighthouseapp.com/attachments/45067/cache_assertions.diff