paperclip

Comments and changes to this ticket

• 

  Gregory Man August 7th, 2008 @ 09:00 PM

  Anyway here's a patch.

  • 0001-Add-instance_methods-check-in-addition-to-column_nam.patch 1.5 KB
• 

  Jon Yurek August 8th, 2008 @ 04:08 PM

  This is a really good point. Shouldn't it also check for a setter, too? There are a bunch of places where paperclip sets attributes via model["attribute_name"] = ... syntax instead of calling methods, so I'm not sure how it would work there. Can you do a little more testing? Thanks.

• 

  Jon Yurek August 8th, 2008 @ 04:08 PM

  • → State changed from “new” to “open”
• 

  Gregory Man August 8th, 2008 @ 06:16 PM

  U right it's really need more tests.

  But we have two ways to this work: 1. Use accessors, and not change plugin code, this will solve problems like mine (then u have huge table, and u don't want to change it)

  1. Change @instance[:"#{@name}filename"] to @instance.send(:"#{@name}filename=") in plugin code, and this will solve not only problem like mine, but much more for example u can define avatarfilename= method in model to write meaning in another cell, than u have database with different cell names for file_name (example: u work with php project on same db).

  I prefer second, and what about u?

• 

  Jon Yurek November 15th, 2008 @ 11:34 AM

  • → State changed from “open” to “resolved”

  I've done this. I changed all the @instance[...] calls to wrappers called instance_read and instance_write.