#2 [PATCH] paperclip returning default url after submit - paperclip

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:id	tickets sorted by id (creation time)
Combine keywords for powerful searching.
Use advanced searching »

#2 √ resolved

[PATCH] paperclip returning default url after submit

Reported by Kamal Fariz | March 27th, 2008 @ 01:26 PM

I have a page where I display the thumbnail and a file field to replace that image. After I upload a file, the app will redirect back to the same page. However, the thumbnail will be replaced with the default url. Only after I reload, the correct url is generated.

I found this was because @file was being set to nil. The patch contains a fix to assign @file from #to_io.

Second part of the patch addresses when submitting the form with other fields present, but no file selected for uploading. Paperclip will again display the default url until reloaded.

I found this was because paperclip was calling flush_write even though not required. This patch shortcircuits the generated accessor.

fix_default_url_after_submit.patch 826 Bytes

Comments and changes to this ticket

Kamal Fariz March 27th, 2008 @ 10:45 PM
Hm .. the patch would break the functionality of deleting the file by setting the attachment to nil I suppose ..
Any ideas to avoid it trampling on @file?
Gaius Centus Novus April 1st, 2008 @ 12:59 PM
My [PATCH] in #5 seems to do about the same thing, though I can't say I entirely understand why. I haven't tried deleting attachments with my version.
Jon Yurek April 1st, 2008 @ 01:53 PM
- → State changed from “new” to “resolved”
I had changed how the default attachment was being stored at one point, and didn't change it completely. Galus was closer in his fix, but the line actually needed to set @file to the default_style's file. I've committed this and it tests clean.